Fix: Support LoginRequiredMiddleware on public Unicorn components#794
Merged
adamghill merged 4 commits intodjango-commons:mainfrom Mar 3, 2026
Merged
Conversation
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
adamghill
reviewed
Feb 22, 2026
JohananOppongAmoateng
force-pushed
the
checksum-errors
branch
from
bea2f25 to
4b222f5
Compare
template_html form_class component_key
JohananOppongAmoateng
force-pushed
the
checksum-errors
branch
from
015f9bf to
8484b6e
Compare
Contributor
Author
|
@adamghill pr rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django 5.1 introduced LoginRequiredMiddleware which redirects all unauthenticated requests to the login page by
default. Because Unicorn communicates via AJAX, components on public pages would silently fail — the browser
received a 302 redirect instead of the expected JSON, causing a token/parse error. Closes #749