Creates an initial newsletter sign-up form - #33
Open
benjaoming wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
|
benjaoming
force-pushed
the
consent-form
branch
from
August 28, 2021 22:24
1449a71 to
e052a2a
Compare
benjaoming
commented
Aug 28, 2021
| source = models.ConsentSource.objects.create( | ||
| source_name="Auto-created default newsletter" | ||
| ) | ||
| return reverse("newsletter:signup", kwargs={"source_id": source.id}) |
Contributor
Author
There was a problem hiding this comment.
This is the really sloppy part. This should be a proper data migration. The /newsletter/ redirect is perhaps useful, but more likely completely useless :)
Contributor
Author
|
(email sent)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design is really off, but this will use django-consent to store the consent of someone. The default consent is currently (wrongly) created in the redirectview of
/newsletter/and is just labeled "auto-created".