uvx --python=3.12 unittest2pytest --write .

[cclauss]

% uvx --python=3.12 unittest2pytest --write . # https://github.com/pytest-dev/unittest2pytest

Like #535 but with a different tool.

• Upgrade from unittest to pytest #535

[acdha]

I think this is a good move — in the past we tried to stick with stdlib only to avoid people struggling around dependency management but the tools have improved a lot and that argument carries a lot less weight now (pysolr turns 20 in 3 years!).

[DhavalGojiya]

Awesome.

[acdha]

My concern with this is that it seems like it could set us up for a future change to cause it to ignore SolrTestCase in its original location since we're mutating that as well. I think we could avoid that risk by making the SolrTestCaseMixin do more of the work in SolrTestCase's constructor so we could import only the mixin, but it feels like there should be a better way to avoid this.

[DhavalGojiya]

My concern with this is that it seems like it could set us up for a future change to cause it to ignore SolrTestCase in its original location since we're mutating that as well. I think we could avoid that risk by making the SolrTestCaseMixin do more of the work in SolrTestCase's constructor so we could import only the mixin, but it feels like there should be a better way to avoid this.

Interesting, and you are absolutely right.
If we set SolrTestCase.__tests__ = False in the test_cloud.py module level file.
Because the module is cached in sys.modules, the same SolrTestCase class object (including the mutated attribute) will be reused and after this test_cloud.py file execution if any other module try to import SolrTestCase class they need to remove the above __tests__= False side effects from the SolrTestCase class, after inherit this class into any new class.
Reference