Prevent duplicate AttributeOptionGroup creation#373
Merged
samar-hassan merged 1 commit intodjango-oscar:mainfrom Jul 15, 2025
Merged
Prevent duplicate AttributeOptionGroup creation#373samar-hassan merged 1 commit intodjango-oscar:mainfrom
samar-hassan merged 1 commit intodjango-oscar:mainfrom
Conversation
Contributor
Author
|
@samar-hassan Kindly review. |
samar-hassan
requested changes
Jul 14, 2025
| self.response = self.put( | ||
| "admin-product-list", | ||
| **{"product_class": "t-shirt", "slug": "oscar-t-shirt-henk"} | ||
| **{"product_class": "t-shirt", "slug": "oscar-t-shirt-henk"}, |
Member
There was a problem hiding this comment.
please remove these trailing commas if its not new code
Member
There was a problem hiding this comment.
please add it again, lint fails
1a73353 to
96f733e
Compare
Member
|
please rebase your branch |
485b507 to
cb1b848
Compare
cb1b848 to
60449de
Compare
samar-hassan
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prevent Duplicate
AttributeOptionGroupCreationResolves: #372
Context
The
optionsfield inAttributeOptionGroupSerializeris defined using:This means the serializer works with data like:
[ {"option": "Large"}, {"option": "Medium"} ]However, when updating existing instances, the model receives options as actual
AttributeOptioninstances:This mismatch caused
find_existing_attribute_option_groupto fail at detecting duplicates — resulting in unnecessary creation of duplicate option groups even when the name and options were the same.What Changed
Updated
find_existing_attribute_option_groupto:Accept and normalize both:
{"option": "Large"}-style dicts from the serializer, andAttributeOptioninstances from the model.Raise clear exceptions (
ValueError,TypeError) for bad input.