-
Notifications
You must be signed in to change notification settings - Fork 20
Style change for the navigation and landing page. Fixed reusability b… #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @UnicornDevCraft 👋 Thanks for doing lots of work here ❤️ I've been longing for someone to refine and improve layout. We made a smaller tweak recently to font sizes and made the menu font black. Got a good feeling that spending time on tweaking font sizes, colors and margins could easily pay off. I need something to be onboard with this PR:
The PR doesn't work for me locally, while bootstrap loads, it doesn't seem to work. I'd love the refactoring into partials to take place in a separate PR, that way they could go in as 100% neutral improvements 👍 |
Hi @benjaoming 👋 Thanks for the thoughtful feedback! The main goal of this PR is to show a concept for improving layout and responsiveness. Since this is just a draft, I wanted to get your opinion early on whether you prefer an incremental approach or are open to something more ambitious. I’ve included screenshots below to help illustrate what’s changed, in case things aren’t rendering correctly locally. If you’re seeing issues, I’d be happy to troubleshoot - feel free to share any error messages or screenshots. Landing hero section: Intro section, part 1: Events tab (layout unchanged but inherits new navbar): Mobile views Layout refactor (for modularity): This approach keeps layouts modular and reusable. The cssClassSuffix parameter allows switching of styles across page types, it's omitted in _index.md. Bootstrap was introduced to enable mobile-first responsiveness: collapsing navbar and flexible grid layout. Current implementation uses CDN. However Bootstrap files can be served locally from /static/, so we can keep the responsiveness benefits without introducing any third-party asset calls, which means no privacy policy needed. Let me know: Thanks again for reviewing! |
THANKS for sharing the screenshots! Very cool to try out reorganizing the content, and I think you've definitely uncovered a way for the landing page to introduce the subject by having the cake and the "happy birthday" message appear un-disturbed on their own 💯 I think I'd prefer to chunk it up slightly, and maybe this order will be the easiest? Let me know what you think? I was thinking to untangle it in this order:
|
…ased on partials.
Rebased and cleaned up a bit, @UnicornDevCraft I'm not sure if you plan to work on this further or no? I think we can keep our current nav as-is, it's basic but does the job. But I really liked the two-column layout you had worked on for the homepage, and how the cake illustration was more visible! |
@thibaudcolas a lot has happened since this PR! We've been talking about the various things and the nav bar is for instance already updated quite significantly! Next thing, that we talked about, is the landing page illustration and main message - to put them side-by-side on a big screen. I think @UnicornDevCraft has a copy of everything here, so I'll close it for now, so it's not confusing. |
…ased on partials.
Please look at the changes, they are not supposed to break other pages.
Let me know if it's too extreme change.