Skip to content

Conversation

ulgens
Copy link
Member

@ulgens ulgens commented Aug 16, 2025

Adds pre-commit config and workflow. I used a pretty small rule set and the diff is relatively small, but because there were to many files with whitespace issues, "files changed" number is a bit higher than I expected.

Please merge with rebase, not squash.

@ulgens ulgens requested a review from benjaoming August 16, 2025 09:36
@ulgens
Copy link
Member Author

ulgens commented Aug 16, 2025

CleanShot 2025-08-16 at 12 37 58@2x

@benjaoming Can you please check the settings, I'm not sure why the new workflow doesn't show up here. Also, we should make "verify hugo" and "pre-commit" checks required (I don't have permission to edit related settings.)

@ulgens ulgens self-assigned this Aug 16, 2025
@ulgens ulgens force-pushed the pre-commit branch 2 times, most recently from 87c3ad9 to b0099cd Compare August 18, 2025 14:40
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this! Unrelated indentation and whitespace stuff has already started sneaking into PRs, so this is helpful!

@benjaoming benjaoming merged commit 0d536d0 into django:main Aug 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants