Add ValidURLRouter to handle unmatched routes (#2147) #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprezz-arthur
force-pushed
the
1-return-4xx-on-unmatched-routes
branch
from
0ccf947 to
de08c46
Compare
You don't seem to have pushed that version 🤔 |
sprezz-arthur
force-pushed
the
1-return-4xx-on-unmatched-routes
branch
from
de08c46 to
ea7535e
Compare
My bad, bad rebase, should be fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #2147.
My attempt to solve the status code 500 on unmatched routes.
Solving it for http requests was quite straight-forward, as I could return 404 directly, but for websocket requests I could only manage to get a 403 by prematurely closing the connection before the handshake.
To make it non-breaking, I opted for extending
URLRouterintoValidURLRouter, as some of the tests intests/test_routing.pyrely on having Exceptions raised.