Skip to content

Conversation

@johanneswilm
Copy link

@johanneswilm johanneswilm commented Dec 17, 2025

This is a possible solution for #2208 in combination with johanneswilm/django-channels-contenttype-test#1

@carltongibson
Copy link
Member

Hey @johanneswilm. Thanks for this.

Initial thought: it looks overly complex. Not a criticism per se. More, I think we made a misstep, and that's an indication of that.

I'll have a play over the holidays

@johanneswilm
Copy link
Author

I agree that it looks complex. I tried to make it as simple as possible and change as little as possible. But there are other solutions - such as rolling back the changes introduced in cd44771 to make the entire test class use the same Daphne process. I am not sure what the benefits of doing that are and whether those benefits outweigh issues such as this one.

@carltongibson
Copy link
Member

No me neither currently 😜 Let me think about it. Thanks for the efforts. Really helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants