Update SI postal codes #531
Merged
+44
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nejec
force-pushed
the
fix-si-postal-codes
branch
from
68201d5 to
331765a
Compare
nejec
force-pushed
the
fix-si-postal-codes
branch
from
331765a to
7af589d
Compare
Woups, looks like my approval was too hasty, a test needs to be updated! |
nejec
force-pushed
the
fix-si-postal-codes
branch
from
7af589d to
573fbe3
Compare
|
Yeah, my bad. Updated and hopefully fixes the tests. |
|
Looks like some more work is needed. |
- updating SI postal codes as per Slovenian Post Office
nejec
force-pushed
the
fix-si-postal-codes
branch
from
573fbe3 to
ee49062
Compare
|
sorry, silly me. I didn't test it before pushing :/ This should pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source for update is official list of postal codes from Post of Slovenia.