Skip to content

Conversation

@sarahboyce
Copy link
Contributor

@sarahboyce sarahboyce commented Dec 14, 2025

@sarahboyce sarahboyce force-pushed the run-tests-django-main branch from b42e2aa to 0c1bf42 Compare December 14, 2025 15:12
@sarahboyce sarahboyce marked this pull request as ready for review December 14, 2025 15:17
Copy link
Member

@ulgens ulgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed, added my comment on the issue: #2391 (comment) Also, even if we consider it needed, I'd recommend adding a test matrix (which we had in the past but removed because it's not needed) and not a new workflow.

@ulgens
Copy link
Member

ulgens commented Dec 15, 2025

One more "change requeest" here would be that we are in the process of moving the test setup to Docker so if we are adding anything, I'd expect them not to ignore the Docker config.

cc @tobiasmcnulty

@sarahboyce sarahboyce marked this pull request as draft December 15, 2025 14:28
@sarahboyce
Copy link
Contributor Author

Marked the pr as draft as need the website wg to agree on the proposal 👍

@ulgens
Copy link
Member

ulgens commented Dec 15, 2025

Marked the pr as draft as need the website wg to agree on the proposal 👍

Adding to the agenda for the next meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Scheduled daily github workflow to run tests using Django's main branch

2 participants