Skip to content

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jan 12, 2026

@ulgens
Copy link
Member

ulgens commented Jan 13, 2026

v0.3.2 seems to be working fine (at least locally), but the check fails with

Makefile linter/analyzer.................................................Failed
- hook id: checkmake
- exit code: 1

  RULE       DESCRIPTION      FILE NAME  LINE NUMBER
   minphony  Required target     Makefile   2
             "all" is missing
             from the Makefile.
   minphony  Required target     Makefile   2
             "clean" is missing
             from the Makefile.
  Error: violations found (2)

I don't have a good idea about what to do with them, @pauloxnet pinging you as the committer of .PHONY: line - any ideas?

@ulgens
Copy link
Member

ulgens commented Jan 14, 2026

I dived a bit deeper and found that checkmake action is recommending to use actions/setup-go for the go dependency and currently we are not doing it. I guess the existing version in the

Adding

   -  uses: actions/setup-go@v6.2.0
      with:
        go-version: 1.25.5

to the related workflow solves

go: go.mod requires go >= 1.25 (running go 1.24.11; GOTOOLCHAIN=local)

issue but we can also check for an alternative tool that does better job at handling its dependencies.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 17219c9 to 5adbf29 Compare January 19, 2026 19:03
updates:
- [github.com/psf/black-pre-commit-mirror: 25.12.0 → 26.1.0](psf/black-pre-commit-mirror@25.12.0...26.1.0)
- [github.com/rbubley/mirrors-prettier: v3.7.4 → v3.8.1](rbubley/mirrors-prettier@v3.7.4...v3.8.1)
- [github.com/mrtazz/checkmake.git: 0.2.2 → v0.3.0](https://github.com/mrtazz/checkmake.git/compare/0.2.2...v0.3.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 8d2cd14 to 295807c Compare January 26, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant