Prevent caching of 404 responses and add regression test #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where 404 responses were being cached, which could cause valid pages to continue returning 404s even after the underlying problem was resolved.
Updated the caching behavior to avoid caching 404 (Not Found) responses
Added a regression test to ensure 404 responses are never cached again
Added a regression test covering the 404 caching scenario
I was unable to run the full test suite locally due to PostgreSQL/Docker environment issues (connection timeout while creating the test database), but the changes are limited in scope and covered by tests
fixes #2341