Skip to content

Integration test tweaks #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djc merged 13 commits into from
Jan 28, 2025
Merged

Integration test tweaks #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
288b33a
integration: apply clippy suggestions
djc Jan 28, 2025
f002242
Rename integration test to pebble
djc Jan 28, 2025
e2eea7c
pebble: use unwrap_or_else() with allocating expression
djc Jan 28, 2025
cf0095d
pebble: detach poll_until_ready() from PebbleEnvironment
djc Jan 28, 2025
7d51314
pebble: use reference to CONFIG
djc Jan 28, 2025
055447f
pebble: simplify config setup
djc Jan 28, 2025
5092c04
pebble: use test harness for Pebble tests
djc Jan 28, 2025
1bf7c89
pebble: initialize HTTP client once
djc Jan 28, 2025
8da56b7
pebble: inline trivial single use method
djc Jan 28, 2025
d2833a3
pebble: avoid double reference
djc Jan 28, 2025
3db0fd5
pebble: inline trait bound
djc Jan 28, 2025
3a6e52b
pebble: use Duration for durations
djc Jan 28, 2025
dd41be4
pebble: keep verification in the test
djc Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pebble.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ jobs:
curl -L "https://github.com/letsencrypt/pebble/releases/latest/download/pebble-challtestsrv-linux-amd64.tar.gz" | tar xz --strip-components=3
chmod +x pebble-challtestsrv
- name: Run integration test
run: RUST_LOG=integration=info cargo test --test integration
run: RUST_LOG=pebble=info cargo test -- --ignored
6 changes: 2 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ required-features = ["hyper-rustls"]
# Pebble integration test.
# Disabled by default because it requires pebble & pebble-challtestsrv.
# Run with:
# PEBBLE=path/to/pebble CHALLTESTSRV=path/to/pebble-challtestsrv cargo test --test integration
# PEBBLE=path/to/pebble CHALLTESTSRV=path/to/pebble-challtestsrv cargo test --test pebble
[[test]]
name = "integration"
harness = false
test = false
name = "pebble"
required-features = ["hyper-rustls"]
Loading