Add support for arbitrary XML in value/extValue#88
Merged
Conversation
Owner
|
Maybe this |
Contributor
Author
|
I agree. I will create a PR with just the ValueElement there. |
This version added support for AnyElement
djc
approved these changes
Feb 25, 2026
Owner
djc
left a comment
There was a problem hiding this comment.
Looks okay!
I think this is semver-breaking? If so, can you add a commit with a semver incompatible version bump (if there isn't one already)?
Per RFC 5730 these contain children of <any> and also have <anyAttribute> Replace the static Undef-only ResultValue with a dynamic ValueElement tree that captures namespace, name, attributes, text, and children from any errValueType content. Update EppResult to support multiple <value> and <extValue> elements (unbounded choice per the spec). Fixes issues where `<epp:undef>` is replaced with concrete object type. See added test for an example.
The previous commits should cover RFC 9038
Contributor
Author
|
Cargo.toml is already at 0.5 but that was never pushed to crates.io and there is no git tag. |
Owner
|
Cool, thanks! Let me know if/when you want a release with this. |
Contributor
Author
|
Currently driving with a fork. I guess it makes sense to wait with a release until I have everything upstreamed (breaking and non breaking). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 5730 these contain children of
<any>and also have<anyAttribute>Replace the static Undef-only ResultValue with a dynamic ValueElement tree that captures namespace, name, attributes, text, and children from any errValueType content. Update EppResult to support multiple
<value>and<extValue>elements (unbounded choice per the spec).Fixes issues where
<epp:undef>is replaced with a concrete object type. See the added tests for examples.There is a rather new spec that gives more context about the extValue and unhandled namespaces with some examples.
https://datatracker.ietf.org/doc/rfc9038/
I am not entirely sure how to cover the
<anyAttribute>on<value>. This for now stores it in a vec with all information from the parser.The schema is:
I guess it could make sense to take this ValueElement and use it as a first impl for djc/instant-xml#115 although the hard part is probably implementing serialize for it, due to the missing stack namespace stack.