Implement comments #170
Open
Implement comments #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks heaps for this! This is a much wanted feature. Will make some time to review this in the next few days and get back to you. One quick one I noticed: It looks like right now it creates comments but doesn't drop them? |
Yes. The former PR did that too, but I will fix that. |
|
Any updates on this? @pauldraper |
|
How are you going with this @pauldraper ? Anything I can help with? Happy to assist with finishing it off also, if that's helpful. |
|
Any updates on this sir? How can I help? |
|
Feel free to take over. I probably won't do anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #45 but with tests.
Depends on djrobstep/schemainspect#65