--exclude_schema -> --exclude-schema #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
Big fan of migra - I'm working on a typescript/nodejs port (which as an aside, would be great to talk about if you're interested). I'm running the test fixtures to validate the port works as expected, and noticed that the CLI arg for
--exclude_schemauses snake case where every other uses kebab case.This adds
--exclude-schema, and deprecates--exclude_schema. I'm not super familiar with argparse/python generally but I tried both out and it seems to work. My tests have a workaround but thought it'd be worth opening a pull request.If it was intentional to use snake case for this one arg, feel free to close.