Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu items to task overview #108

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

dkhalife
Copy link
Owner

@dkhalife dkhalife commented Mar 4, 2025

No description provided.

@Copilot Copilot bot review requested due to automatic review settings March 4, 2025 00:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds new task overview features by introducing delete functionality and enhancing the due date handling.

  • Adds a delete task flow with confirmation modal
  • Updates due date modal usage to accept a date parameter
  • Refactors table headers and integrates new MUI icons

Reviewed Changes

File Description
src/views/Tasks/TasksOverview.tsx Introduces delete task flow and parameterizes due date modal calls
src/views/Modals/Inputs/DateModal.tsx Adjusts the open method signature and input type to datetime-local
src/views/Tasks/TaskCard.tsx Updates due date modal invocation to pass next_due_date

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/views/Tasks/TasksOverview.tsx:170

  • Throwing an error here may cause the application to crash unexpectedly. Consider handling the missing task scenario with a user-friendly notification or safe return.
throw new Error('Task to delete is not set')

src/views/Tasks/TasksOverview.tsx:48

  • [nitpick] The variable name 'taskBeingDeleted' could be made more descriptive, such as 'selectedTaskForDeletion', to better convey its purpose.
private taskBeingDeleted: Task | null = null

src/views/Tasks/TaskCard.tsx:137

  • Ensure that 'this.props.task.next_due_date' is a valid Date object before passing it to the DateModal 'open' method to avoid potential formatting issues.
this.dateModalRef.current?.open(this.props.task.next_due_date)
@dkhalife dkhalife merged commit c6f9125 into main Mar 4, 2025
5 checks passed
@dkhalife dkhalife deleted the add-menu-items-to-overview branch March 4, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant