Skip to content

Fix TestScheduleStop: replace cron.FuncJob injection with real *Job lifecycle #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcastellm merged 2 commits into from
Mar 29, 2026
Merged

Fix TestScheduleStop: replace cron.FuncJob injection with real *Job lifecycle #1955

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d83420
Initial plan
Copilot Mar 29, 2026
5e22e81
fix: rewrite TestScheduleStop to use real *Job instead of cron.FuncJo…
Copilot Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions dkron/scheduler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
package dkron

import (
"fmt"
"testing"
"time"

"github.com/distribworks/dkron/v4/extcron"
"github.com/robfig/cron/v3"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
Expand Down Expand Up @@ -95,29 +92,25 @@ func TestScheduleStop(t *testing.T) {
log := getTestLogger()
sched := NewScheduler(log)

sched.Cron = cron.New(cron.WithParser(extcron.NewParser()))
_, err := sched.Cron.AddFunc("@every 2s", func() {
time.Sleep(time.Second * 5)
fmt.Println("function done")
})
require.NoError(t, err)
sched.Cron.Start()
sched.started = true

testJob1 := &Job{
Name: "cron_job",
Schedule: "@every 2s",
Schedule: "@every 10m",
Executor: "shell",
ExecutorConfig: map[string]string{"command": "echo 'test1'", "shell": "true"},
Owner: "John Dough",
OwnerEmail: "foo@bar.com",
}

// Start the scheduler with a real job
err := sched.Start([]*Job{testJob1}, &Agent{})
require.NoError(t, err)

// Starting again while already started should return an error
err = sched.Start([]*Job{testJob1}, &Agent{})
assert.Error(t, err)

// Wait for the job to start
time.Sleep(time.Second * 2)
<-sched.Stop().Done()

err = sched.Start([]*Job{testJob1}, &Agent{})
assert.NoError(t, err)

Expand Down
Loading