Skip to content

Prometheus metrics. Configurable timeout and memory limit#758

Closed
andreygolev wants to merge 1 commit intodkron-io:mainfrom
andreygolev:shell_executor_prometheus_metrics
Closed

Prometheus metrics. Configurable timeout and memory limit#758
andreygolev wants to merge 1 commit intodkron-io:mainfrom
andreygolev:shell_executor_prometheus_metrics

Conversation

@andreygolev
Copy link
Copy Markdown
Contributor

Here were have:

  • configurable timeout for job execution
  • configurable memory limit for a shell job
  • prometheus realtime cpu and memory consumption while it's working
  • prometheus push style metrics after job execution. Useful for monitoring if job was executed in time (that's how we found misses of executions). Also there: exit code, duration of a job, last execution timestamp,

In cases anyone needs it, we can add a flag to turn on/off metrics expose through prometheus.

Copy link
Copy Markdown
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution thanks! But can you split this in several PRs each one with one of the features?

@vcastellm
Copy link
Copy Markdown
Member

Should we close this @andreygolev or do you want to update it?

@vcastellm
Copy link
Copy Markdown
Member

Closing in favor of #1798

@vcastellm vcastellm closed this Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants