Incorporate feedback for the AI@2025#12
Conversation
There was a problem hiding this comment.
Hey @edyoshikun,
It's looking great, and seems to mostly run on the VMs! The main issue I found is that the cell computing SSIM/Dice seems to break for me, due to an unexpected dim given to cellpose. I've suggested the change.
I also had to play around a bit with the paths to the downloaded data. Are they all gonna download the data, or they'll use it from the shared mount?
Here's my other minor feedback/suggestions:
- In the
log_batch_jupyter, it'd be nice to addcmap=grayto display the images for coherency with the tensorboard viz. - In the alert containing several code snippets, It'd be nice to add the line to load phase2fluor model user trains in case there's a crash, laptop sleeps, nb disconnection, etc. (I made the suggestion, feel free to accept/ignore!)
Lmk if anything is unclear 🙂
adjavon
left a comment
There was a problem hiding this comment.
It seems good to me aside from a few minor comments! There are some types/organization things that I've been adding as I go along. I'll push those once I've merged them with your other changes :)
There was a problem hiding this comment.
A couple of quick notes:
- The import cell took surprisingly long to run (~45s)
- To use
iohubin the terminal (in VSCode) they will also have to set the environment there. We could have them select the interpreter (in VSCode preferences)? - In "Visualize segmentation comparison: Fluorescence vs Virtual Staining vs Pretrained" it is getting: "Resizing is depricated in v4.0.1+" a few times --> this seems to be a cellpose issue?
…ts for computing metrics
Minor suggestions
This PR addresses #10 with following :
README.mdto remove thePart 1andPart2since we are consolidating this exercise.