Conversation
Author
|
When looking at other PRs, I just noticed that there is a version for the filesystem in version.h. I'll leave it as-is and let whomever merges set it to the next version at that time. |
Author
|
Brought up to current and flashed with no issues. Will verify with DFM sonde launch in the morning. |
Author
|
Have verified with several DFM17 launches. Still working as expected. |
Author
|
@dl9rdz any thoughts, concern, questions, etc.? I'll hold on keeping this in sync, but happy to get it ready to merge and test again at any time if you are interested in merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added configurable parameter replacing "define SONDEHUB_MAXAGE 15". This is particularly helpful for the DFM radiosondes and emulates the guidance that projecthorus gives for auto_rx.
https://github.com/projecthorus/sondehub-infra/wiki/DFM-radiosonde-above-1000-and-not-enough-data-to-perform-z-check
Ideally, the logic would be to submit every 10 valid decoded packets whether that took 10 seconds or a minute (maybe with a max timeout) when decoding a DFM sonde, but that's beyond my comfort with the codebase at this point.
I did set a minimum of 15 seconds in case someone updates the firmware without updating the filesystem. If that should be handled differently, feel free to update or let me know how you'd like it fixed.