Skip to content

fix half ratings#6

Open
alexkuz wants to merge 1 commit intodlau:masterfrom
alexkuz:master
Open

fix half ratings#6
alexkuz wants to merge 1 commit intodlau:masterfrom
alexkuz:master

Conversation

@alexkuz
Copy link

@alexkuz alexkuz commented Oct 19, 2015

Currently half ratings are shown incorrectly for some currentRating values (e.g. 4.2 shows as 3 and a half stars). This fix implements this logic:

currentRating < 0.25 - shows empty star,
0.25 <= currentRating < 0.75 - shows half star,
0.75 <= currentRating - shows full star.

@amitthakkar22288
Copy link

although the half stars work now, the onChange does not send down the accurate value (2.5), instead it sends down 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants