Skip to content

fix redirect messaging #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bugfood
Copy link
Contributor

@bugfood bugfood commented Apr 25, 2025

If --ignore-redirects is set, then a line of code several lines above here is assigning:

server = args.server

...so the conditional 'server != args.server' is only met when --ignore-redirects is unspecified.

Note that the conditional removed in this commit was also backwards, so prior to this change, gp-saml-gui would print the wrong message when --ignore-redirects was not specified.

If --ignore-redirects is set, then a line of code several lines above
here is assigning:

    server = args.server

...so the conditional 'server != args.server' is only met when
--ignore-redirects is unspecified.

Note that the conditional removed in this commit was also backwards, so
prior to this change, gp-saml-gui would print the wrong message when
--ignore-redirects was not specified.
@bugfood
Copy link
Contributor Author

bugfood commented Apr 25, 2025

This change removes the message:

IMPORTANT: During the SAML auth, you were redirected from <foo> to <bar>, however the redirection was ignored because you specified --ignore-redirects

I don't think we need that message; if the user specifies --ignore-redirects, then I think the program doesn't need to say that it's doing as requested.

I could easily change that if desired, though; please let me know.

Thanks,
Corey

@bugfood
Copy link
Contributor Author

bugfood commented Apr 25, 2025

The test failure seems to be unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant