Skip to content

feat: add selenium as alternative webview for authentication #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coldcoff
Copy link

This contribution adds the possibility to have different WebView implementations.
Your GTK WebKit is the default, if detected, an alternative is now Selenium. More can be added easily.

For me this is useful, because it adds the possibility to use my YubiKey.

While working on it I added some documentation for CentOS to the README and fetched a username hint from the initial PaloAlto response, that I use for the Selenium implementation lateron. (Probably this can be used in the WebKit implementation as well, but that would be a different PR).

Any questions or remarks, please let me know ;-)

@coldcoff
Copy link
Author

Any chance to look at this, @dlenski ?

@coldcoff
Copy link
Author

Any news here?

@iamkroot
Copy link

On a related note, I have a WIP implementation of using Playwright for the same purpose- https://github.com/iamkroot/gp-saml-gui/tree/playwright
My approach is slightly different, but seems reconcilable.

@coldcoff
Copy link
Author

That sounds interesting as well! I did not know about playwright before, thanks for that heads-up.

Yeah, reconciliation sounds like a good idea.

I know of these approaches:
#57 (Selenium)
https://github.com/iamkroot/gp-saml-gui/tree/playwright (PlayWright)
https://github.com/abg1979/gp-saml-gui/commits/master (wxPython / wxCEF)
#26 (pyqt5, not a PR, though)

Most of the forks/issues would solve the "cookie is not in headers" issue / rfe as well, just as bycatch.

Time for @dlenski to show up, sort the feedback and contributions, set the tracks as project owner, then we can contribute accordingly and bring the pieces together.

@coldcoff
Copy link
Author

coldcoff commented Aug 8, 2024

This is used now on a daily basis by about two dozen people.
Any chance to get that merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants