Fixes and improvements for MSVC, add Windows builds to CI #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues that prevented the code from compiling with Visual Studio:
DUPLO_VERSIONis not defined in the vcxproj which makes the code not compile. I chose to make the define optional.I also took the chance of adding some tweaks and improvements to
CMakeLists.txtso that it works with MSVC, as well.Finally, I added Windows builds to CI.