Skip to content

Conversation

@chausner
Copy link
Contributor

@chausner chausner commented Feb 15, 2025

This fixes a couple of issues that prevented the code from compiling with Visual Studio:

  • DUPLO_VERSION is not defined in the vcxproj which makes the code not compile. I chose to make the define optional.
  • Release builds with MSVC fail due to a compiler warning (treated as error).
  • Updated the platform toolset version for Visual Studio 2022
  • Some source and header files were missing in Duplo.vcxproj which I added.

I also took the chance of adding some tweaks and improvements to CMakeLists.txt so that it works with MSVC, as well.

Finally, I added Windows builds to CI.

@chausner chausner changed the title Fixes and improvements for MSVC Fixes and improvements for MSVC, add Windows builds to CI Feb 15, 2025
@dlidstrom
Copy link
Owner

@chausner Thanks a TON!!! This was on my bad conscience for years. I'll happily merge this 💪🏻

@dlidstrom dlidstrom merged commit ebd5583 into dlidstrom:master Feb 15, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants