fix potential undefined behavior in cgif_addframe#112
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes undefined behavior in cgif_addframe’s frame-comparison loop by preventing signed integer overflow when computing the pixel count (width * height), addressing issue #110.
Changes:
- Switches the per-pixel comparison loop bound from
width * heighttoMULU16(width, height)to avoid signed-int promotion overflow. - Updates the loop index type from
inttouint32_tto match the (potentially large) pixel-count domain.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #110