Fixed Issue #37 #42
Fixed Issue #37 #42
Conversation
added language en, de, fr and public possibilty to switch
| matchesLabel.setText(matchCount + " matches"); | ||
| } | ||
| pageLabel.setText(getTranslation("Page", (item.getPageNumber() + 1))); | ||
| matchesLabel.setText(getTranslation("Matches", item.getItems().size())); |
There was a problem hiding this comment.
This does not handle the same situations as the original code. I explicitly want to write "1 match" and "2 matches" (singular, plural).
There was a problem hiding this comment.
Just saw the resource bundle. I didn't know that this is possible. So you can specify this to use either singular or plural translation? If so then I learned something new today :-)
| } | ||
| } | ||
|
|
||
| public void loadLanguageProperties(String language) { |
There was a problem hiding this comment.
I do not know any JavaFX controls that explicitly add methods for translating the control. This should happen automatically. The control should pickup the required language bundle based on the language currently used by the JVM. If you need to be able to switch languages at runtime then you need to subclass the control and add the feature there.
…class to enable translations in PDFView and PDFViewSkin
dlemmermann
left a comment
dlemmermann
left a comment
There was a problem hiding this comment.
Why is there a "Translation" class. Why can't we simply use the default way of working with Resource Bundles. Blog: https://medium.com/@medcherrou/understanding-resourcebundle-in-java-a-comprehensive-guide-2cb3b49edf03
| private Properties languageProperties = new Properties(); | ||
|
|
||
| public String getTranslation(String languageString, Object ... arguments) { | ||
| if(languageProperties.isEmpty()){ |
There was a problem hiding this comment.
Please use default IntelliJ formatting. I noticed that a space is missing after the "if".
There was a problem hiding this comment.
This comment is superseded by my remarks regarding the use of a proper ResourceBundle.
| loadLanguageProperties(); | ||
| } | ||
| String message = languageString; | ||
| if (languageProperties != null) { |
There was a problem hiding this comment.
These two if-statements can be merged.
There was a problem hiding this comment.
This comment is superseded by my remarks regarding the use of a proper ResourceBundle.
2 participants
added language en, de, fr and public possibilty to switch