Skip to content

fix: text and binary precision supported #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Jun 4, 2025

Description

The SQLGlot libs module had a remaining breakpoint() and didn't support dlt data types text and binary. This is now fixed and implemented

@zilto zilto requested a review from sh-rp June 4, 2025 01:49
Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 3799c40
🔍 Latest deploy log https://app.netlify.com/projects/dlt-hub-docs/deploys/6849875a9d562c0008e35fa2

@zilto zilto self-assigned this Jun 4, 2025
@zilto zilto added the bug Something isn't working label Jun 4, 2025
@zilto zilto force-pushed the fix/sqlglot-libs branch from 6851b9c to e1f81c0 Compare June 10, 2025 15:02
zilto and others added 7 commits June 11, 2025 09:28
* first pass formatting raise statements

* added custom exception

* updated Exception classes

* linting & formatting

* fixed tests

* fix imports

* capitalize argument to please mypy

* add raise keyword

* applied review comments

* passing tests

* fixed test

* fixed broken check logic

* format

* fixes bigquery test

---------

Co-authored-by: Marcin Rudolf <[email protected]>
…#2710)

* Clarify dlt resource and rest_api specific parameters

* Add resource name param
* use both pull request and pull request target on destination workflows

* remove additional triggers

* marks one test as smoke test and only runs this for the time being

* only run one test in common, needs to be reverted later

* run common tests only on linter success

* fix common workflow

* only start workflows on call (do not call them yet)

* test master workflow

* remove docs changes step from lint

* remove local destinations docs change

* rename master trigger workflows

* change concurrency key

* try other dependencies

* add destination tests with authorize step

* remove authorize and docs step from destination tests

* fix destination test

* rename main workflow

* test inherit secrets

* add more workflows to main file

* fix starting conditions for some workflows

* rename plus tests matrix job

* remove concurrency settings for now

* add first remote destinations workflow version

* move some more remote destinations

* remove pytest args

* try to fix extras string

* add more remote destination tests

* rename some workflows and add concurrency settings to main workflow

* move test_destinations

* fix link to called workflow

* add better main workflow labels
move clickhouse remote tests

* create local destinations test

* disabled some workflows

* disable clickhouse oss for now
split duckdb and postgres local tests into own matrix job

* copy ssh agent key

* move all local destination secrets into template secrets file

* small fixes

* enable all tests again

* fix local tests

* add missing openai dep

* try to fix qdrant creds

* fix qdrant server / local file differentiation

* fix cli test

* change workflow dependencies

* remove telemetry info and other small changes

* run dummy destination with the local tests

* remove duckdb from remote tests,
always run all mssql and postgres tests

* enable clickhouse oss

* fix condition for always running all tests

* move cli commands to postgres tests

* rename clickhouse-compose to be inline with other services

* fix clickhouse local credentials and disable tests which require staging destinations

* adapt postgres to postgres example to new fixture

* fix clickhouse excluded configs

* update essential test handling

* skip gcs compat test for local clickhouse tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants