CrateDB: Add destination adapter #2733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
amotl
commented
Jun 9, 2025
Comment on lines
58
to
64
| def info_schema_null_to_bool(v: str) -> bool: | ||
| """Converts INFORMATION SCHEMA truth values to Python bool""" | ||
| if v in ("NO", "0"): | ||
| if v in ("NO", "0", False): | ||
| return False | ||
| elif v in ("YES", "1"): | ||
| elif v in ("YES", "1", True): | ||
| return True | ||
| raise ValueError(v) |
There was a problem hiding this comment.
We already created a ticket about this little anomaly.
amotl
force-pushed
the
cratedb
branch
3 times, most recently
from
3068348 to
4df27ac
Compare
This was referenced Jun 9, 2025
amotl
commented
Jun 9, 2025
This was referenced Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
A destination adapter for CrateDB, which is compatible with PostgreSQL.
Thoughts
We hear you. Still, we wanted to submit this patch for inspection at your disposal. Because the adapter is effectively just wrapping the
postgresadapter, adding a few adjustments, it doesn't introduce many different technologies or paradigms. Given the smaller footprint compared to other adapters, you may still consider merging it? 🙏Software tests