Skip to content

fix: return empty list instead of null when user explicitly sets [] #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BohdanTkachenko wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: return empty list instead of null when user explicitly sets [] #1248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions internal/codegen/templates/convert.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,13 @@ func {{ .Name }}ToXML(ctx context.Context, model *{{ .Name }}Model) (*libvirtxml
return nil, fmt.Errorf("converting {{ .GoName }} to List: %s", diags.Errors()[0].Summary())
}
model.{{ .GoName }} = listVal
} else if plan != nil && !plan.{{ .GoName }}.IsNull() {
// User explicitly set an empty list - return empty list to preserve intent
listVal, diags := types.ListValueFrom(ctx, types.ObjectType{AttrTypes: {{ .NestedStruct.Name }}AttributeTypes()}, []{{ .NestedStruct.Name }}Model{})
if diags.HasError() {
return nil, fmt.Errorf("converting {{ .GoName }} to List: %s", diags.Errors()[0].Summary())
}
model.{{ .GoName }} = listVal
} else {
model.{{ .GoName }} = types.ListNull(types.ObjectType{AttrTypes: {{ .NestedStruct.Name }}AttributeTypes()})
}
Expand All @@ -251,6 +258,13 @@ func {{ .Name }}ToXML(ctx context.Context, model *{{ .Name }}Model) (*libvirtxml
return nil, fmt.Errorf("converting {{ .GoName }} to List: %s", diags.Errors()[0].Summary())
}
model.{{ .GoName }} = listVal
} else if plan != nil && !plan.{{ .GoName }}.IsNull() {
// User explicitly set an empty list - return empty list to preserve intent
listVal, diags := types.ListValueFrom(ctx, {{ .ElementType }}, xml.{{ .GoName }})
if diags.HasError() {
return nil, fmt.Errorf("converting {{ .GoName }} to List: %s", diags.Errors()[0].Summary())
}
model.{{ .GoName }} = listVal
} else {
model.{{ .GoName }} = types.ListNull({{ .ElementType }})
}
Expand Down