fix: allow integer fields with value 0 to be returned correctly #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the codegen template incorrectly treated integer values of 0 as null/empty when converting XML to Terraform state. This caused PCI address fields (domain, bus, slot, function) with value 0 to be returned as null, resulting in "Provider produced inconsistent result after apply" errors. Most PCI devices have domain=0, and many have slot=0 or function=0 (e.g., 0000:03:00.0), making PCI passthrough unusable without workarounds. The fix removes the `!= 0` checks from convert.go.tmpl: - For pointer fields: only check `!= nil` - For non-pointer fields: always set the value This affects 8 locations in the template covering computed, optional, and flattened value attribute fields. Fixes perpetual drift for PCI passthrough devices where any address component equals 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the codegen template incorrectly treated integer values of 0 as null/empty when converting XML to Terraform state. This caused PCI address fields (domain, bus, slot, function) with value 0 to be returned as null, resulting in "Provider produced inconsistent result after apply" errors.
Most PCI devices have domain=0, and many have slot=0 or function=0 (e.g., 0000:03:00.0), making PCI passthrough unusable without workarounds.
The fix removes the
!= 0checks from convert.go.tmpl:!= nilThis affects 8 locations in the template covering computed, optional, and flattened value attribute fields.
Fixes #1246: perpetual drift for PCI passthrough devices where any address component equals.