Adds React Fragment.
#1224
Draft
Adds React Fragment.
#1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjio
force-pushed
the
react-fragment
branch
2 times, most recently
from
65e30f7 to
bcc770c
Compare
This adds the [React Fragment](https://react.dev/reference/react/Fragment) feature. This adds a fourth case to `VTree` DSL, `VFrag`. This accounts for returning bulk sets of nodes from a 'Component'. This allows the inling of nodes from a child component into a parent component, avoiding interemdiate placeholder nodes from entering the DOM. This also means that a parent node list can contain children from potentially n-many different components. Like React, this also changes event delegation to be global across all currently mounted 'Component'. - [x] Add `VFrag` case in Haskell / TypeScript. - [x] Update `mountComponent()` callback to pass in `parent` - [x] Remove `+>` , in favor of simpler `mount` combinator. - [x] Make event delegation global, drop `continue` case in `event.ts`
dmjio
force-pushed
the
react-fragment
branch
from
bcc770c to
3878901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the React Fragment feature.
This adds a fourth case to our
VTreeDSL (VFrag). This accounts for returning bulk sets of nodes from a component. This allows the inling of nodes from a child component into a parent component, avoiding interemdiate placeholder nodes from entering the DOM. This also means that a parent node list can contain children from potentially n-many different components.Like React, this also makes event delegation global across all currently mounted 'Component', previously each Component had its own delegation.
VFragcase in Haskell / TypeScript.mountComponent()callback to pass inparent+>, in favor of simplermountcombinator.continuecase inevent.tsVTreealong with currently delegated events (those listened on bymountPoint(typically<body>)Supercedes #1221
cc @ners