Add Property data type
#1263
Draft
Add Property data type
#1263
+57
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should remove intermediate allocations of `Value` during `View m a` construction. - [x] Constrain `prop` on `ToJSVal a => a` - [x] Define `integerProp` in terms of `doubleProp`. There is no `ToJSVal` on `Integer`, users can marshall their `Integer` into a `Double`, or we can add a custom `BigInt` (non-IE compatible). Previously `integerProp` was marshalled into a `Scientific` value and then converted into a JS `float`. Defining `integerProp` in terms of `doubleProp` is identical to this.
Owner
Author
|
Make sure this is tested on the JS backend, w/ WASM it might be slower because it uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove intermediate allocations of
ValueduringView m aconstruction inbuildVTree, for selectpropcombinators. Using the most genericpropcombinator is now discouraging in favor of more specifictextProp,doubleProp,intProp.Propertydata type.integerPropin terms ofdoubleProp.There is no
ToJSValonInteger, users can marshall theirIntegerinto aDouble, or we can add a customBigInt(non-IE compatible). PreviouslyintegerPropwas marshalled into aScientificvalue and then converted into a JSfloat.Defining
integerPropin terms ofdoublePropis identical to this.This should have a dramatic performance improvement on rendering large strings, since we now bypass calls to
textFromJSString.