Skip to content

fetch example: use servant-client-js, remove Miso.Fetch #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 1, 2025

Conversation

amesgen
Copy link
Contributor

@amesgen amesgen commented May 1, 2025

This PR removes the Servant functionality from Miso.Fetch, instead recommending users to use servant-client-core with a backend of their choice, while recommending servant-client-js.

The commits can be reviewed individually.

Background on servant-client-core

The general idea of servant-client-core is as follows:

Footnotes

  1. Third-party adaptors usually also provide instances in a separate -client package, see e.g. servant-auth-client.

@amesgen amesgen force-pushed the servant-jsaddle branch from 92a8b31 to ca672c9 Compare May 1, 2025 16:02
amesgen added 3 commits May 1, 2025 23:07
Also make sure that we use jsaddle-wasm 0.1.1, which contains an important bug
fix for servant-client-js to work.
@amesgen amesgen changed the title fetch example: use servant-client-core, remove Miso.Fetch fetch example: use servant-client-js, remove Miso.Fetch May 1, 2025
@amesgen amesgen force-pushed the servant-jsaddle branch from ca672c9 to 3e2eb94 Compare May 1, 2025 21:34
@amesgen amesgen force-pushed the servant-jsaddle branch from 3e2eb94 to 6955485 Compare May 1, 2025 21:38
@amesgen amesgen marked this pull request as ready for review May 1, 2025 22:12
@dmjio dmjio merged commit 2a954b9 into dmjio:master May 1, 2025
3 checks passed
@amesgen amesgen deleted the servant-jsaddle branch May 1, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants