Skip to content

Bump maven version, freeze CUDA packages.#92

Merged
trivialfis merged 3 commits into
dmlc:mainfrom
trivialfis:update-mvn
Jun 12, 2026
Merged

Bump maven version, freeze CUDA packages.#92
trivialfis merged 3 commits into
dmlc:mainfrom
trivialfis:update-mvn

Conversation

@trivialfis

Copy link
Copy Markdown
Member

Extracted from #91 to unblock the CI.

@trivialfis trivialfis temporarily deployed to containers-staging June 12, 2026 09:29 — with GitHub Actions Inactive
@trivialfis trivialfis changed the title Bump maven version. Bump maven version, freeze CUDA packages. Jun 12, 2026
@trivialfis trivialfis temporarily deployed to containers-staging June 12, 2026 09:38 — with GitHub Actions Inactive
@trivialfis trivialfis requested a review from Copilot June 12, 2026 10:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is extracted from #91 to unblock CI by pinning/freeze behavior for CUDA packages during Rocky Linux CUDA image updates, bumping the Maven version used in JVM images, and deduplicating gosu installation logic across container Dockerfiles.

Changes:

  • Add a RockyLinux-focused CUDA setup script that version-locks installed CUDA RPMs before running dnf update.
  • Add a shared install_gosu.sh script and update multiple Dockerfiles to use it.
  • Bump MAVEN_VERSION from 3.9.15 to 3.9.16 in JVM container images.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
containers/scripts/setup_cuda_rockylinux.sh New helper to lock CUDA RPMs and standardize RockyLinux CUDA repo key setup + update flow.
containers/scripts/install_gosu.sh New helper to centralize gosu download/installation across images.
containers/dockerfile/Dockerfile.manylinux2014_x86_64 Switch to shared gosu installer script.
containers/dockerfile/Dockerfile.manylinux2014_aarch64 Switch to shared gosu installer script.
containers/dockerfile/Dockerfile.manylinux_2_28_x86_64 Switch to shared gosu installer script.
containers/dockerfile/Dockerfile.manylinux_2_28_aarch64 Switch to shared gosu installer script.
containers/dockerfile/Dockerfile.jvm_gpu_build Bump Maven version; use shared CUDA setup + gosu installer scripts.
containers/dockerfile/Dockerfile.jvm Bump Maven version; use shared gosu installer script.
containers/dockerfile/Dockerfile.i386 Switch to shared gosu installer script.
containers/dockerfile/Dockerfile.gpu_build_rockylinux8 Use shared CUDA setup + gosu installer scripts.
containers/dockerfile/Dockerfile.gpu_build_r_rockylinux8 Use shared CUDA setup + gosu installer scripts.
containers/dockerfile/Dockerfile.gpu_build_cuda13_rockylinux8 Use shared CUDA setup + gosu installer scripts.
containers/dockerfile/Dockerfile.gpu Switch to shared gosu installer script.
containers/dockerfile/Dockerfile.cpu_build_r_doc Switch to shared gosu installer script.
containers/dockerfile/Dockerfile.cpu Switch to shared gosu installer script.
containers/dockerfile/Dockerfile.clang_tidy Switch to shared gosu installer script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread containers/scripts/setup_cuda_rockylinux.sh
Comment thread containers/scripts/install_gosu.sh

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

@trivialfis trivialfis merged commit 0d8e1fb into dmlc:main Jun 12, 2026
24 checks passed
@trivialfis trivialfis deleted the update-mvn branch June 12, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants