Skip to content

update LightGBM links #12084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jameslamb wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

update LightGBM links #12084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R-package/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ if(ENABLE_ALL_WARNINGS)
endif()

if(MSVC)
# https://github.com/microsoft/LightGBM/pull/6061
# https://github.com/lightgbm-org/LightGBM/pull/6061
# MSVC doesn't work with anonymous types in structs. (R complex)
#
# syntax error: missing ';' before identifier 'private_data_c'
Expand Down
4 changes: 2 additions & 2 deletions cmake/FindOpenMPMacOS.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ endmacro()
# Patch libxgboost.dylib so that it depends on @rpath/libomp.dylib instead of
# /opt/homebrew/opt/libomp/lib/libomp.dylib or other hard-coded paths.
# Doing so enables XGBoost to interoperate with multiple kinds of OpenMP
# libraries. See https://github.com/microsoft/LightGBM/pull/6391 for detailed
# explanation. Adapted from https://github.com/microsoft/LightGBM/pull/6391
# libraries. See https://github.com/lightgbm-org/LightGBM/pull/6391 for detailed
# explanation. Adapted from https://github.com/lightgbm-org/LightGBM/pull/6391
# by James Lamb.
# MacOS only.
function(patch_openmp_path_macos target target_default_output_name)
Expand Down
2 changes: 1 addition & 1 deletion src/objective/lambdarank_obj.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ class LambdaRankObj : public FitIntercept {
auto lj = GroupLoss(g, &lj_full_);

// Normalization, first used by LightGBM.
// https://github.com/microsoft/LightGBM/pull/2331#issuecomment-523259298
// https://github.com/lightgbm-org/LightGBM/pull/2331#issuecomment-523259298
double sum_lambda{0.0};

auto delta_op = [&](auto const&... args) {
Expand Down
Loading