Require Enum from polars.#12240
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the Python Polars data ingestion path to explicitly reject polars.Categorical columns (due to potentially sparse encodings) and requires users to provide polars.Enum instead, updating the Polars integration test accordingly.
Changes:
- Add a Polars dtype guard that raises a
ValueErrorwhen apolars.Categoricalcolumn is detected. - Update
test_with_polars.pyto expect the rejection ofCategoricaland validateEnum’s Arrow dictionary/indices behavior. - Refresh the test file copyright header.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/python/test_with_polars.py | Updates categorical test to require pl.Enum and assert the new rejection behavior for pl.Categorical. |
| python-package/xgboost/data.py | Introduces _reject_polars_categorical and applies it during Polars → Arrow transformation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #12182