-
Notifications
You must be signed in to change notification settings - Fork 18
curl installer #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl installer #18
Conversation
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
varlock-website | d7875e8 | Visit preview | May 14 2025, 07:33 PM |
commit: |
afc722f to
a4cf270
Compare
17fab98 to
a4cf270
Compare
e386ec2 to
3a3689d
Compare
philmillman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
we may want to an action that does a quick smoke test to install it and maybe run a command to verify the installation
|
should we default to add it to their PATH as well? |
8371cd5 to
1291365
Compare
1291365 to
4272b30
Compare
adds a bash install script, meant to be consumed via curl, via some redirecting/shortened url, for example:
curl -sSfL https://varlock.dev/install.sh | sh -sThe script is fetching our homebrew tap/formula to determine the current latest version. A simpler method used by other projects is to rely on github's "latest" release, but because we release multiple packages from our monorepo, and changesets creates a release for each, there is no guarantee that the "latest" will be a varlock release. Fetching from our homebrew formula is a little weird, but it will keep the 2 install methods in sync, and we are already updating that file with the latest version number. Fetching it from anywhere else would mean keeping yet another thing in sync.
One other option would be fetching that version number from npm, but the npm package gets published via changesets before the binary release workflow runs - so there is a short time where these 2 things may not be in sync.
Some other notes
--force-no-brewflag is set~/.varlock/bin(we anticipate shoving other stuff in there)future improvements to the install script could be