Skip to content

Fixed deprecation warnings, flake8 of code and added python and django's to travis#74

Open
GitRon wants to merge 8 commits into
dmpayton:developfrom
GitRon:feature/deprecation-warnings
Open

Fixed deprecation warnings, flake8 of code and added python and django's to travis#74
GitRon wants to merge 8 commits into
dmpayton:developfrom
GitRon:feature/deprecation-warnings

Conversation

@GitRon

@GitRon GitRon commented Aug 7, 2020

Copy link
Copy Markdown
  • Fixed django 4.0 deprecation warnings
  • flake8 of code
  • added python 3.5, 3.6 and 3.8 to travis
  • added django 3.1 to travis
  • created a travis matrix so all valid combinations are being tested
  • added some tags to the README

@GitRon

GitRon commented Aug 7, 2020

Copy link
Copy Markdown
Author

Hi @dmpayton

I fixed the deprecations and did some more stuff but the tests seems to fail now even though I didn't change anything at these points. Do you know if it was maybe broken before?

Thanks!
Ronny

@GitRon

GitRon commented Aug 7, 2020

Copy link
Copy Markdown
Author

Btw, I extended the travis matrix so we get proper check for all the relevant pyhton and django combinations.

@9mido

9mido commented Aug 8, 2020

Copy link
Copy Markdown

Awesome work @GitRon ! Would you also be able to make a PR for issue 62? That way, the newest version for django 3 compatibility will get pushed to PyPi along with your PR.

@GitRon

GitRon commented Aug 11, 2020

Copy link
Copy Markdown
Author

@9mido quite busy at the moment but I'll see what I can do

@GitRon

GitRon commented Sep 1, 2020

Copy link
Copy Markdown
Author

@9mido I put this idea into a PR. Happy? :)

@9mido

9mido commented Sep 1, 2020

Copy link
Copy Markdown

@GitRon Yes you rock! Woohoo!

Just wondering though the checks for it look like they have failed. Any ideas how to fix those?

I feel really dumb the PR you made looks very simple lol.

@GitRon

GitRon commented Dec 4, 2020

Copy link
Copy Markdown
Author

@dmpayton @9mido Pipeline is fixed and PR is ready to merge.

@GitRon

GitRon commented Dec 14, 2020

Copy link
Copy Markdown
Author

@dmpayton @9mido Would be awesome if somebody could review and merge it 😃

@blag

blag commented Nov 26, 2021

Copy link
Copy Markdown

Hi, I have forked this project, included a few PRs (including this one), and released a package to PyPI. You might have better luck with my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants