[pull] main from MetaMask:main#318
Merged
Merged
Conversation
## Explanation Releasing EarnController 7.0.0 which includes BIP-44 updates to use AccountTreeController. ## References Related to this issue: https://consensyssoftware.atlassian.net/browse/TAT-1315 And this PR: https://consensyssoftware.atlassian.net/browse/TAT-1315 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
#6447) ## Explanation This change renames the QuoteError event to QuotesError, and InputSourceDestinationFlipped event to InputSourceDestinationSwitched in order to match the approved [segment schema](https://github.com/Consensys/segment-schema/pull/264/files) <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> Fixes https://consensyssoftware.atlassian.net/browse/SWAPS-2768 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
`@metamask/eip-5792-middleware` was incorrectly initialized with a version of `1.0.0`. We need to initialize packages with a version of 0.0.0 before publication.
Reverts #6446 because it was not published correctly due to version being set incorrectly on a new package. This has since been fixed, but we're reverting to re-attempt this publish.
## Explanation Add the `includeInStateLogs` and `usedInUi` state metadata properties. This is the implementation of the second option of this ADR: MetaMask/decisions#101 The `deriveStateFromMetadata` function has also been exported, rather than adding two new exports for these new properties. The previous exported state derivation functions (`getPersistedState` and `getAnonymizedState`) have been deprecated in favour of `deriveStateFromMetadata`. ## References Related to MetaMask/decisions#101 Fixes #6443 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
## Explanation Releasing EarnController 7.0.0 which includes BIP-44 updates to use AccountTreeController. ## References Related to this issue: https://consensyssoftware.atlassian.net/browse/TAT-1315 And this PR: https://consensyssoftware.atlassian.net/browse/TAT-1315 ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
In c4de052, some of the `network-controller` tests were reorganized. Unfortunately this causes an issue when using the compiled version of the package in clients. Having both a `create-network-client.ts` file and a `create-nework-client/` directory (with no link between the two) seems to confuse either `ts-bridge` or the TypeScript compiler, as it generates a version of `create-auto-managed-network-client.ts` with an invalid import path for `create-network-client.ts` (that is, it should end with either `.cjs` or `.mjs` depending on the variant being generated, but it does not). Renaming the `create-network-client/` directory seems to fix the issue.
## Explanation Initial release for `@metamask/eip-5792-middleware` ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )