[pull] main from MetaMask:main#321
Merged
Merged
Conversation
…d in MultichainNetworkController (#6455) ## Explanation Bitcoin networks are not enabled by default in the Network Enablement Controller, causing the `enabledNetworks` object to show Bitcoin as an empty namespace (`"bip122": {}`) instead of showing Bitcoin mainnet as enabled. This is inconsistent with how Solana networks are handled. This discrepancy is cashing a crash in Flask builds This change makes Bitcoin networks follow the same enablement pattern as Solana networks: 1. Default state: Bitcoin mainnet is now enabled by default in Flask builds alongside Ethereum and Solana 2. Initialization: The `init()` method enables Bitcoin mainnet if it exists in MultichainNetworkController configurations 3. Popular networks: The enableAllPopularNetworks() method now includes Bitcoin mainnet enablement ## References Fixes [#12345](MetaMask/metamask-mobile#19201) ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
## Explanation The new metadata properties `includeInStateLogs` and `usedInUi` have been added to the sample controllers. ## References Relates to #6443 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
## Explanation The `SafeEventEmitterProvider` `'data'` event relies on the `JsonRpcEngine` `'notification'` event, which per #6327 we are trying to get rid of. After failing to find an instance outside of tests where we actually use the `'data'` event, we assess that it can be removed. ## References * Ref: #6327 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes (really just checking that CI passes in this case) - MetaMask/metamask-extension#35498 - MetaMask/metamask-mobile#18907
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )