[pull] main from MetaMask:main#783
Merged
Merged
Conversation
…oved}` events (#8770) ## Explanation Now handles all group updates in case groups gets created/updated or removed. We still filter those events with the currently selected account group before forwarding this to the Snaps. ## References N/A ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes how selected accounts are forwarded into the legacy Snap keyring by adding new AccountTreeController lifecycle event handlers; bugs here could desync Snap-selected accounts from the UI-selected group. > > **Overview** > Extends `SnapAccountService` to listen for `AccountTreeController:accountGroupCreated`, `:accountGroupUpdated`, and `:accountGroupRemoved` and update the legacy Snap keyring’s selected accounts when (and only when) the affected group is currently selected. > > Refactors forwarding into `#forwardSelectedAccounts` with shared logging/error handling, adds helpers for fetching the selected group and group object, and updates mirrored types/tests/changelog to include group `id` and the new events. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 866a677. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )