-
Notifications
You must be signed in to change notification settings - Fork 37
Extensions support #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gauravyad69
wants to merge
67
commits into
dmzz-yyhyy:refactoring
Choose a base branch
from
gauravyad69:extensions_support
base: refactoring
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Extensions support #270
gauravyad69
wants to merge
67
commits into
dmzz-yyhyy:refactoring
from
gauravyad69:extensions_support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the app Introduces extension functionality, allowing users to add and manage custom content sources. - Implements extension manager for handling extensions - Adds UI for browsing, installing, and managing extensions - Introduces repository support for extension distribution - Adds example extension for testing purposes - Creates database tables for extensions and repositories - Updates gradle and gitignore files
- Introduces ExtensionLoader for loading, saving, and deleting extensions. - Adds ExtensionReadingService to handle book and chapter retrieval from extensions. - Updates ExtensionManager to support fetching chapters from extensions. - Implements BrowseViewModel and InstalledViewModel for managing UI state in browsing and installed extensions. - Enhances UI components for browsing and managing installed extensions, including error handling. - Updates strings.xml with new UI strings for better user experience.
- Adds RepositoryInitializer to manage default repositories from Shosetsu. - Integrates repository initialization in MainActivity and RepositoriesViewModel. - Introduces RepositoryInfoDialog for displaying information about Shosetsu repositories. - Updates RepositoriesScreen to allow users to add default repositories and view repository information. - Adds new strings for UI elements related to repository management.
- Updated RepositoryService to handle new data structure from Shosetsu, including changes to versioning and description fields. - Modified RepoIndex model to include authors, libraries, scripts, styles, and JS. - Enhanced RepositoryRemoteDataSource to accommodate .lua file extensions for Shosetsu repositories. - Added refresh functionality in RepositoriesViewModel to allow users to refresh all repositories. - Updated RepositoriesScreen UI to include a refresh button for better user interaction. - Added new string resource for the refresh action.
…cements - Added ExtensionExplorationHomeScreen and ExtensionSearchScreen for browsing and searching novels from installed extensions. - Introduced ExtensionExplorationViewModel to manage UI state and handle data fetching for available extensions and search results. - Updated navigation to include exploration routes and integrated exploration options in the main UI. - Enhanced ExtensionReadingService to generate unique book IDs based on extension information. - Added new string resources for exploration-related UI elements.
…rdcoded as .lua, will make dynamic later) format and fix repository download logic
First, let's improve the extension loader to handle proper extension loading: 2. Fix Extension-to-Book ID Mapping Let's create a proper book ID encoding/decoding system 3. Create Extension Book Mapping Database Table
-Create Extension Settings System -Create Extension Settings Manager
…and fall back to the regular web service if no extension book is found.
Refactored luaextenion into smaller file
This reverts commit b702f91.
… to get novels to appear
update the converter, the extensions show up in the drop down
…ic data source management to avoid not switching to desrired source - Added DelegatingWebDataSource to switch between built-in and extension data sources at runtime and avoid error. - Introduced ReactiveWebDataSource for automatic updates when extensions are loaded. - Updated WebDataSourceModule to use DelegatingWebDataSource for improved data source resolution.
…r better debugging and extension handling
…ties -removed mock to test out the real onces
…ement, and improve data source integration, revert the book repository back to original
…to integers (which was failing), I use the chapter index (0, 1, 2...) as the chapter ID that the UI sees Original ID Preservation: Store a mapping between (bookId, chapterIndex) and the original chapter ID from the extension Proper Chapter Loading: When getChapterContent is called, look up the original chapter ID and pass that to the extension
48ef920 to
e291371
Compare
Contributor
Author
|
so what do we do? |
Owner
|
sorry i am not online in weekday. the detail about the pr is explained by yukonisen in discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.