[PTFM-39459] Perform per part checksum integrity checks on writable symlinks #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpradhan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.internal.dnanexus.com/browse/PTFM-39459
Previous change to implement per-part checksum integrity checks applied only to readable symlinks.
This PR ensures that per-part checksum integrity checks are performed on writable symlinks instead.
This also removes the previous inefficiency of loading the readable symlink into memory after the download. So now the integrity check is performed while the writable symlink file is downloaded.
Also adds unit test for the integrity checks.