Skip to content

Conversation

@eesoyeon
Copy link
Collaborator

@eesoyeon eesoyeon commented Aug 30, 2025

#️⃣ 연관된 이슈 (선택)

ex) #이슈번호, #이슈번호

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

Summary by CodeRabbit

  • 신기능
    • 비교 페이지의 "내 구독" 섹션에서 커스텀 구독이 자동으로 제외되어 기본 제공 구독만 표시됩니다. 목록이 더 간결하게 보입니다.
    • 구독 서비스 항목에 커스텀 여부를 나타내는 선택적 속성이 추가되어, 앱이 커스텀 구독을 인식해 표시 및 필터링에 반영합니다.

@eesoyeon eesoyeon self-assigned this Aug 30, 2025
@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link

coderabbitai bot commented Aug 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

SubscriptionService 타입에 선택적 필드 isCustom이 추가되었고, ComparisonPage에서 mySubs.services 중 isCustom이 아닌 항목만 필터링해 ComparisonMySubSection에 전달하도록 데이터 흐름이 조정되었습니다. API 시그니처 변경은 없으며, 표시 데이터의 부분집합만 달라집니다.

Changes

Cohort / File(s) Summary
Subscription 타입 확장
src/entities/subscription/api/fetchMySubscription.ts
SubscriptionService 타입에 isCustom?: boolean 속성을 추가하여 서비스 객체의 데이터 형태를 확장
비커스텀 구독만 비교 섹션에 전달
src/pages/comparison/ComparisonPage.tsx
filteredNotCustom = mySubs.services.filter(sub => !sub.isCustom) 추가 후, ComparisonMySubSection에 전달하는 props를 전체 목록에서 비커스텀 목록으로 변경

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant CP as ComparisonPage
  participant API as fetchMySubscription
  participant MS as ComparisonMySubSection

  U->>CP: 페이지 진입
  CP->>API: 내 구독 조회
  API-->>CP: { services: SubscriptionService[ { ..., isCustom? } ] }

  rect rgb(235, 245, 255)
    note right of CP: 신규 흐름
    CP->>CP: services.filter(sub => !sub.isCustom)
  end

  CP->>MS: props: filteredNotCustom
  MS-->>U: 비커스텀 구독 목록 렌더링
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

🐛 BugFix

Poem

귀가 살짝 파닥, 코드에 봄바람 불어와요 🐰
isCustom 살짝 얹고, 나는 골라 담죠—Not custom만 쏙!
비교 섹션은 말끔, 데이터 흐름은 가지런—탁.
작은 필터 하나로, 화면은 더 또렷해졌지.
삐약 삐약 버그야, 당근은 내가 챙긴다! 🥕


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4b48272 and 1a54613.

📒 Files selected for processing (2)
  • src/entities/subscription/api/fetchMySubscription.ts (1 hunks)
  • src/pages/comparison/ComparisonPage.tsx (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/comparison

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ✨ Feature 기능 개발 📨 Api 서버 Api 통신 labels Aug 30, 2025
@eesoyeon eesoyeon merged commit 3c4ebac into develop Aug 30, 2025
1 of 2 checks passed
@eesoyeon eesoyeon deleted the feature/comparison branch August 30, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📨 Api 서버 Api 통신 ✨ Feature 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants