Skip to content

Conversation

@ujinsim
Copy link
Collaborator

@ujinsim ujinsim commented Sep 2, 2025

🚀 기능 추가

-README 업데이트

🏗 작업 내용

  • 이미지 추가 시 GitHub Issue 업로드 링크를 README에 그대로 옮기면 로드가 되지 않아, 불가피하게 docs/ 폴더에 이미지를 업로드하는 방식으로 변경했습니다.
  • 만약 다윗님 로컬 환경에서 기존 방식이 정상적으로 동작한다면, 이 부분은 삭제 후 다시 올려주셔도 괜찮습니다 🙇‍♂️

👀 관련 이슈 번호

@ujinsim ujinsim requested a review from ydw1996 as a code owner September 2, 2025 09:34
@coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs/#98

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ujinsim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 README.md 파일을 전면적으로 업데이트하여 프로젝트의 목적, 주요 기능, 사용된 기술 스택 및 팀 구성에 대한 포괄적인 정보를 제공합니다. 기존의 Next.js 기본 템플릿 내용을 제거하고, 프로젝트의 핵심 내용을 명확하게 전달하는 데 중점을 두었습니다. 특히, 이미지 로딩 문제를 해결하기 위해 이미지 파일의 저장 위치를 변경했습니다.

Highlights

  • README 업데이트: 기존 Next.js 기본 README 내용을 프로젝트 소개, 기능, 기술 스택, 팀 정보 등으로 완전히 대체했습니다.
  • 이미지 경로 변경: GitHub Issue 업로드 링크가 로드되지 않아, 이미지를 docs/ 폴더로 옮기고 README에서 해당 경로를 참조하도록 변경했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@vercel
Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
zipzip Ready Ready Preview Comment Sep 9, 2025 10:58am

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

프로젝트의 README.md 파일을 create-next-app 기본 템플릿에서 프로젝트에 맞는 상세한 설명으로 업데이트하는 좋은 변경입니다. 전체적으로 프로젝트를 이해하기 쉽게 잘 작성되었습니다. 다만, 일부 링크가 플레이스홀더로 되어 있거나 깨져 있는 부분이 있어 수정을 제안합니다. 자세한 내용은 아래 리뷰 코멘트를 확인해주세요.

README.md Outdated
# 🏡 내 기준에 맞는 집 .zip! 해서 후회없게

## Getting Started
[![Storybook](https://img.shields.io/badge/Storybook-FF4785?style=flat-square&logo=storybook&logoColor=white)](https://<스토리북-배포-주소>)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

스토리북 배포 주소가 아직 정해지지 않았다면 괜찮지만, 현재는 링크가 플레이스홀더 <스토리북-배포-주소>로 되어 있어 동작하지 않습니다. 실제 배포 주소로 업데이트하는 것을 잊지 않도록 주의해주세요.

Copy link
Member

@ydw1996 ydw1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다 .. ㅎㅎ 추후에 프론트 엔드 아키텍처랑 기술스택 정리해서
리드미 작성해봐요!!

@ujinsim ujinsim marked this pull request as ready for review September 9, 2025 10:59
@dnd-side-project dnd-side-project deleted a comment from gemini-code-assist bot Sep 9, 2025
@ujinsim ujinsim merged commit 9f5e5cb into main Sep 9, 2025
6 checks passed
@ujinsim ujinsim deleted the docs/#98 branch September 9, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants