Skip to content

Grammar fix for README.md #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −3
Open

Grammar fix for README.md #807

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ec15c9
Grammar fix for README.md
mattias-lonn Nov 20, 2022
152acb4
Update README.md
mattias-lonn Nov 20, 2022
f0b86a5
Update README.md
mattias-lonn Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Draw SVG files using Flutter.
## Getting Started

This package provides a wrapper around Dart implementations of SVG parsing,
including SVG path data. In particular, it provides efficient `BytesLoader`
including SVG path data. In particular, it provides an efficient `BytesLoader`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right. Implementations is plural.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, removed the added "an".

implementations for [`package:vector_graphics`](https://pub.dev/packages/vector_graphics).
This package is easier to use but not as performant as using the
`vector_graphics` and `vector_graphics_compiler` packages directly. Those
Expand Down Expand Up @@ -108,8 +108,8 @@ See the `vector_graphics_compiler` package for more details.

## Recommended Adobe Illustrator SVG Configuration
- In Styling: choose Presentation Attributes instead of Inline CSS because CSS is not fully supported.
- In Images: choose Embded not Linked to other file to get a single svg with no dependency to other files.
- In Objects IDs: choose layer names to add every layer name to svg tags or you can use minimal,it is optional.
- In Images: choose Embed not Linked to other file to get a single svg with no dependency to the other files.
- In Objects IDs: choose layer names to add every layer name to svg tags or you can use minimal, it is optional.
![Export configuration](https://user-images.githubusercontent.com/2842459/62599914-91de9c00-b8fe-11e9-8fb7-4af57d5100f7.png)

## SVG sample attribution
Expand All @@ -127,7 +127,7 @@ SVGs in `/assets/wikimedia` are pulled from [Wikimedia Commons](https://commons.
Android Drawables in `/assets/android_vd` are pulled from Android Documentation
and examples.

The Flutter Logo created based on the Flutter Logo Widget © Google.
The Flutter Logo was created based on the Flutter Logo Widget © Google.

The Dart logo is from
[dartlang.org](https://github.com/dart-lang/site-shared/blob/master/src/_assets/images/dart/logo%2Btext/horizontal/original.svg)
Expand Down