Draft: Improve perf for long log lines#7
Draft
seeseemelk wants to merge 2 commits into
Draft
Conversation
This caches calls to eventSize(), which in our case were consuming a significant amount of CPU usage. When you're logging many large log lines, one can quickly exceed the MAX_BATCH_SIZE limit. At this point, it will calculate the size of each log event twice (once as part of drainBatchFromQueue->batchSize, and once as drainBatchFromQueue->eventSize). The eventSize method internally calls `String#getBytes`, which calls `String#encodeUTF8`. For large log lines, this call is quite expensive. Calling it twice is just unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you're logging many large log lines, one can quickly exceed the AsyncWorker#MAX_BATCH_SIZE limit.
At this point, the AsyncWorker will calculate the size of each log event twice (once as part of drainBatchFromQueue->batchSize, and once as drainBatchFromQueue->eventSize).
The eventSize method internally calls
String#getBytes, which callsString#encodeUTF8.For large log lines, this call is quite expensive. Calling it twice is just unnecessary.