Skip to content

chore: sync listCharges fixture with certificate-purchase entry#109

Merged
ggalmazor merged 2 commits intomainfrom
chore/sync-list-charges-fixture
Apr 18, 2026
Merged

chore: sync listCharges fixture with certificate-purchase entry#109
ggalmazor merged 2 commits intomainfrom
chore/sync-list-charges-fixture

Conversation

@ggalmazor
Copy link
Copy Markdown
Contributor

@ggalmazor ggalmazor commented Apr 17, 2026

Syncs the listCharges fixture with upstream dnsimple/dnsimple-developer#986.

Adds a certificate purchase entry to demonstrate that product_reference is a string even when the reference is a numeric ID.

Note: this client does not yet implement a Billing service, so there are no tests to update — only the fixture is synced.

Checklist

  • Close and re-open this PR to trigger the CI workflow (it does not run automatically)
  • Ensure the CI workflow passes before merging

@ggalmazor ggalmazor added the task Task to be performed label Apr 17, 2026
@ggalmazor ggalmazor self-assigned this Apr 17, 2026
@ggalmazor ggalmazor requested a review from jacegu April 17, 2026 14:48
@ggalmazor
Copy link
Copy Markdown
Contributor Author

No test changes in this PR because the Rust client does not currently implement a Billing service. A quick audit confirms:

  • src/dnsimple/ has no billing.rs module and no Charge / ChargeItem structs.
  • tests/ has no billing or charges test file.
  • grep -ri "billing\|charge" src/ tests/ returns no matches outside the fixture itself.

The listCharges/success.http fixture exists as a stub for a future Billing implementation, but no code consumes it today. Because there's no consumer, there's no failing assertion to drive via TDD — syncing the fixture is the only applicable change here.

Once a Billing service lands in this client, the sync'd fixture will be ready to back its tests (including the certificate-purchase case that motivates the upstream fixture change).

@ggalmazor ggalmazor merged commit 1e4adde into main Apr 18, 2026
5 checks passed
@ggalmazor ggalmazor deleted the chore/sync-list-charges-fixture branch April 18, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task Task to be performed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants