fix: contact phone and fax import when values are empty#326
Open
alexhuk3 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes contact phone and fax fields not being populated during import or refresh when the current state value is empty or unknown.
Why
When importing contacts, the API returns values for phone and fax, and also provides
phone_normalizedandfax_normalized.However, the provider only populated the normalized fields, while
phoneandfaxcould remain empty in state.This caused an extra update right after import.
How
During contact read:
always set
phone_normalizedandfax_normalizedfrom the API response (contact.Phone / contact.Fax).if
phoneand/orfaxis empty, backfill it from the same API value (contact.Phone / contact.Fax) to avoid a post-import update